feat: Add DoubleTapCallbacks that receives double-tap events. #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzanardo
reviewed
Feb 7, 2023
Co-authored-by: Erick <erickzanardoo@gmail.com>
spydon
reviewed
Feb 8, 2023
packages/flame/lib/src/events/component_mixins/double_tap_callbacks.dart
Outdated
Show resolved
Hide resolved
packages/flame/lib/src/events/component_mixins/double_tap_callbacks.dart
Outdated
Show resolved
Hide resolved
packages/flame/test/events/component_mixins/double_tap_callbacks_test.dart
Outdated
Show resolved
Hide resolved
packages/flame/test/events/component_mixins/double_tap_callbacks_test.dart
Outdated
Show resolved
Hide resolved
packages/flame/test/events/component_mixins/double_tap_callbacks_test.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
spydon
approved these changes
Feb 9, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As-is
As mentioned in #2321, the user needs to propagate double-tap events to the component tree using
DoubleTapDetector&propagateToChildrenuntil now.To-be
DoubleTapCallbacksreceive double-tap-related events.Same as
DragCallbacks, there is no need to add mixin to the game likeHasDoubleTapCallbaksas before.Discussion
DoubleTapCallbackscan replaceDoubleTapDetectorbecause it is a mixin that can be added to the FlameGame too. ShouldDoubleTapDetectorbe marked as deprecated?Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #2321