Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RecycleQueue cannot extends and implements Iterable at the same time #2497

Merged
merged 1 commit into from Apr 14, 2023

Conversation

erickzanardo
Copy link
Member

Description

Implementing and extending the iterable interface/mixin at the same time breaks Flame in the current beta channel (3.10...).

This PR removes the implementation of the interface to get flame ready for the next flutter release.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@erickzanardo erickzanardo requested review from st-pasha and a team April 14, 2023 13:08
@erickzanardo erickzanardo merged commit 3e5be3d into main Apr 14, 2023
6 checks passed
@erickzanardo erickzanardo deleted the fix/recycled_queue branch April 14, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants