Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Release instead of dispose audioplayer in play #2513

Merged
merged 1 commit into from Apr 19, 2023
Merged

Conversation

spydon
Copy link
Member

@spydon spydon commented Apr 19, 2023

Description

The AudioPlayer should not be disposed when it should be continued to be used, it should be released.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

bluefireteam/audioplayers#1475

@spydon spydon merged commit e699b25 into main Apr 19, 2023
7 checks passed
@spydon spydon deleted the spydon/fix-bgm branch April 19, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants