fix: Fix disappearing text on TextBoxComponent for larger pixelRatios #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanpotter
commented
May 17, 2023
Comment on lines
+249
to
+250
| scaledSize.x.ceil(), | ||
| scaledSize.y.ceil(), |
There was a problem hiding this comment.
this was also wrong - width and height would be referring to the previous this.size and not the parameter size witch is the new size. but this was not the source of the issue in my case
luanpotter
commented
May 17, 2023
| game.addAll([ | ||
| TextBoxComponent( | ||
| text: 'quickly', | ||
| pixelRatio: 8, |
There was a problem hiding this comment.
this was more than enough to cause issues to me.
on my application anything more than 2.51 was causing issues.
the test seems to be a little more lenient - it appears to be dependent on the actual size of the canvas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When updating to the new Flutter & Flame version I was forced to revisit the occurences of
window.pixelRatioand realized there is actually a bug on TextBoxComponent for certain pixelRatios (depending on the size of the Canvas).The bug only manifests after a certain pixelRatio for each base size because while the canvas is created with the unscaled size, it does appear to be able to "render" outside of it's bounds for the most times. However I imagine there must be some optimization under the hood, and after a certain size increment, the rendering is void.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?