fix: Tiled component orthogonal test #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzanardo
changed the title
erickzanardo
commented
May 26, 2023
packages/flame_tiled/lib/src/renderable_layers/renderable_layer.dart
Outdated
Show resolved
Hide resolved
spydon
approved these changes
Jun 5, 2023
kurtome
reviewed
Jun 5, 2023
Comment on lines
109
to
112
| final anchor = camera.viewfinder.anchor; | ||
| final cameraX = camera.viewfinder.position.x; | ||
| final cameraY = camera.viewfinder.position.y; | ||
| final viewportCenterX = camera.viewport.size.x * anchor.x; | ||
| final viewportCenterY = camera.viewport.size.y * anchor.y; | ||
| final viewportCenterX = camera.viewport.size.x / 2; | ||
| final viewportCenterY = camera.viewport.size.y / 2; |
There was a problem hiding this comment.
Did you test this in Flame and compare it to Tiled? I originally verified everything lined up by hand
erickzanardo
commented
Jun 6, 2023
|
|
||
| // Need to initialize a game and call `onLoad` and `onGameResize` to | ||
| // get the camera and canvas sizes all initialized | ||
| final game = FlameGame(children: [world, cameraComponent]); | ||
| await game.ready(); | ||
| cameraComponent.viewfinder.anchor = Anchor.center; |
There was a problem hiding this comment.
So, following up the logic that we need to apply the camera's anchor to the parallax, I thought that, hey, maybe the code previously was already correct, but with the previous camera, tiled was always considering a center camera, hence why it was doing a / 2, which would make the generated snapshots be based on a Anchor.center camera.
So for the test to pass, I just changed the camera's anchor on the test to center, to match the previous behaviour, which seems to make sense to me.
Let me know if this also make sense to you all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #2548