Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Make world nullable in CameraComponent #2615

Merged
merged 1 commit into from Jul 19, 2023
Merged

Conversation

ufrshubham
Copy link
Collaborator

Description

CameraComponent can now stare at nothingness because its world reference can be null now.

Checklist

  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Migration instructions

CameraComponent.world is now nullable. While accessing it, make sure to perform null checks if it can be null in your case. Otherwise, if you are sure that the world is non-null perform unconditional using CameraComponent.world!.

Related Issues

Closes #2614

@spydon spydon merged commit 14f5163 into main Jul 19, 2023
6 checks passed
@spydon spydon deleted the devkage/looking-into-void branch July 19, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow possibility of CameraComponent without a world
2 participants