New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add optional world input to CameraComponent.canSee
#2616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I wonder if it is worth looking up the component's world, since this method is used for culling it needs to be as efficient as possible. Maybe just allow for an optional world to be sent in that the component belongs to? Or just write in the dartdoc that the user should check that it belongs to the camera component's world first, it's probably a very niche use-case when that check needs to be performed anyways.
The mounted check is good though!
CameraComponent.canSee
CameraComponent.canSee
Decided to go with this.
Also added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
Description
CameraComponent.canSee
wasn't performing any kind of sanity checks on the given components world or mounted-ness. This PR adds these checks to correctly return false if the component is not mounted or if the optional world is not the same as camera's current target world.Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues
NA