Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding key argument to shape components #2632

Merged
merged 1 commit into from Aug 2, 2023
Merged

feat: Adding key argument to shape components #2632

merged 1 commit into from Aug 2, 2023

Conversation

erickzanardo
Copy link
Member

@erickzanardo erickzanardo commented Jul 31, 2023 •
edited

Description

Components based on ShapeComponent were missing the key constructor argument. This PR addresses that.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@erickzanardo erickzanardo requested a review from a team July 31, 2023 22:08
@erickzanardo erickzanardo changed the title feat: adding key argument to shape components feat: Adding key argument to shape components Jul 31, 2023
@erickzanardo erickzanardo merged commit c542d3c into main Aug 2, 2023
7 of 13 checks passed
@erickzanardo erickzanardo deleted the feat/shape-components-key branch August 2, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@wolfenrain wolfenrain wolfenrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erickzanardo @spydon @wolfenrain