Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improve comments and documentation for text-rendering Nodes #2662

Merged
merged 1 commit into from Aug 20, 2023
Merged

docs: Improve comments and documentation for text-rendering Nodes #2662

merged 1 commit into from Aug 20, 2023

Conversation

luanpotter
Copy link
Member

Description

Improve comments and documentation for text-rendering Nodes
Super-specify return types whenever possible
Minor refactorings to improve legibility

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@spydon spydon merged commit 96978e2 into main Aug 20, 2023
6 checks passed
@spydon spydon deleted the luan.doc-node-type branch August 20, 2023 10:13
@luanpotter luanpotter mentioned this pull request Aug 26, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@st-pasha st-pasha Awaiting requested review from st-pasha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luanpotter @spydon