Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flame_jenny): Public access to variables to allow load/save #2689

Merged
merged 4 commits into from Aug 28, 2023

Conversation

projectitis
Copy link
Contributor

Description

Allows direct access to the variables in the VariableStorage class in jenny (via YarnProject.variables.variables).

This enables a user to implement a save game feature to save the variables and later restore them.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #2687

@projectitis
Copy link
Contributor Author

Looks like the test runner timed out. How can I restart the tests?

@spydon
Copy link
Member

spydon commented Aug 27, 2023

Looks like the test runner timed out. How can I restart the tests?

You can't, but I restarted it now, no idea why GitHub has started to kill that step.

@spydon spydon requested a review from st-pasha August 27, 2023 19:49
@projectitis
Copy link
Contributor Author

I'm going to go out on a limb and suggest that my change did not break collision detection 🤣

@spydon
Copy link
Member

spydon commented Aug 28, 2023

I'm going to go out on a limb and suggest that my change did not break collision detection 🤣

Ah you managed to hit both of the test pipeline problems. 😅
That collision detection test most likely hits some rounding error sometimes and therefore becomes flaky, something that should be looked into.

@spydon spydon merged commit 1485f84 into flame-engine:main Aug 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improvement(Jenny): Ability to load and save data
2 participants