Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ambiguation is not needed in render box anymore #2711

Merged
merged 4 commits into from Sep 10, 2023
Merged

fix: Ambiguation is not needed in render box anymore #2711

merged 4 commits into from Sep 10, 2023

Conversation

spydon
Copy link
Member

@spydon spydon commented Sep 8, 2023

Description

Since we are requiring a SDK higher than when the instance could be null we don't need to do the ambiguate call anymore.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

luanpotter
luanpotter approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spydon spydon enabled auto-merge (squash) September 10, 2023 13:43
@spydon spydon merged commit b3d78f5 into main Sep 10, 2023
7 checks passed
@spydon spydon deleted the spydon/remove-render-box-ambiguate branch September 10, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luanpotter luanpotter luanpotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spydon @luanpotter