Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid creating new Vector2 in globalToLocal and localToGlobal #2727

Merged
merged 2 commits into from Sep 11, 2023
Merged

fix: Avoid creating new Vector2 in globalToLocal and localToGlobal #2727

merged 2 commits into from Sep 11, 2023

Conversation

spydon
Copy link
Member

@spydon spydon commented Sep 11, 2023

Description

Since globalToLocal and localToGlobal are called a lot when gestures are being triggered we should try to minimize the amount of new Vector2 objects created here.

Checklist

  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

luanpotter
luanpotter approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really really really want us to just use tuples. We need to take a look at this.

@spydon spydon enabled auto-merge (squash) September 11, 2023 17:07
@spydon spydon merged commit 9fb3bf8 into main Sep 11, 2023
7 checks passed
@spydon spydon deleted the spydon/avoid-vector2-in-projection branch September 11, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luanpotter luanpotter luanpotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spydon @luanpotter