Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add advanced button component #2742

Merged
merged 65 commits into from Oct 10, 2023
Merged

feat: Add advanced button component #2742

merged 65 commits into from Oct 10, 2023

Conversation

denisgl7
Copy link
Contributor

@denisgl7 denisgl7 commented Sep 18, 2023 •
edited

Description

New button with support for multiple states:
image

Checklist

  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

@denisgl7 denisgl7 changed the title add advanced button component feat!: add advanced button component Sep 18, 2023
@denisgl7 denisgl7 changed the title feat!: add advanced button component feat!: Add advanced button component Sep 18, 2023
spydon
spydon reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is not a breaking change, so you don't need the exclamation mark on feat!.

packages/flame/lib/src/components/input/advanced_button_component.dart Show resolved Hide resolved
packages/flame/lib/src/components/input/advanced_button_component.dart Outdated Show resolved Hide resolved
packages/flame/lib/src/components/input/advanced_button_component.dart Outdated Show resolved Hide resolved
packages/flame/lib/src/components/input/advanced_button_component.dart Outdated Show resolved Hide resolved
packages/flame/lib/src/components/input/advanced_button_component.dart Outdated Show resolved Hide resolved
packages/flame/lib/src/components/input/advanced_button_component.dart Outdated Show resolved Hide resolved
@denisgl7 denisgl7 changed the title feat!: Add advanced button component feat: Add advanced button component Sep 18, 2023
erickzanardo
erickzanardo reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but we need a test for this new component.

@spydon
Copy link
Member

spydon commented Sep 18, 2023

Changes LGTM, but we need a test for this new component.

And docs, and a small example :)

@denisgl7
Copy link
Contributor Author

Changes LGTM, but we need a test for this new component.

And docs, and a small example :)

It's clear here.
But how to write tests for a component? Where can I see an example?

@spydon
Copy link
Member

spydon commented Sep 18, 2023

@denisgl7 here is an example of a component test, there are lots in that directory that you can have a look at:
https://github.com/flame-engine/flame/blob/main/packages/flame/test/components/button_component_test.dart

spydon
spydon reviewed Sep 21, 2023
View reviewed changes
doc/flame/inputs/other_inputs.md Outdated Show resolved Hide resolved
doc/flame/inputs/other_inputs.md Outdated Show resolved Hide resolved
doc/flame/inputs/other_inputs.md Outdated Show resolved Hide resolved
doc/flame/inputs/other_inputs.md Outdated Show resolved Hide resolved
doc/flame/inputs/other_inputs.md Outdated Show resolved Hide resolved
doc/flame/inputs/other_inputs.md Outdated Show resolved Hide resolved
doc/flame/inputs/other_inputs.md Outdated Show resolved Hide resolved
denisgl7 and others added 22 commits October 9, 2023 16:02
@denisgl7 @spydon
Update packages/flame/lib/src/components/input/toggle_button_componen…
7d54944 
…t.dart

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@denisgl7 @spydon
Update packages/flame/lib/src/components/input/toggle_button_componen…
edaca7b 
…t.dart

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@denisgl7 @spydon
Update packages/flame/lib/src/components/input/toggle_button_componen…
4f1384b 
…t.dart

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@denisgl7 @spydon
Update examples/lib/stories/input/advanced_button_example.dart
107bd0c 
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@denisgl7 @spydon
Update packages/flame/lib/src/components/input/advanced_button_compon…
955c455 
…ent.dart

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@denisgl7 @spydon
Update doc/flame/inputs/other_inputs.md
2e50637 
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@denisgl7 @spydon
Update packages/flame/lib/src/components/input/advanced_button_compon…
ae0aa20 
…ent.dart

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@denisgl7 @spydon
Update packages/flame/lib/src/components/input/advanced_button_compon…
a2e9c53 
…ent.dart

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@denisgl7 @spydon
Update packages/flame/lib/src/components/input/advanced_button_compon…
072dc48 
…ent.dart

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@denisgl7 @spydon
Update packages/flame/lib/src/components/input/advanced_button_compon…
95f2e69 
…ent.dart

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@denisgl7 @spydon
Update packages/flame/lib/src/components/input/advanced_button_compon…
f667223 
…ent.dart

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@denisgl7 @spydon
Update packages/flame/lib/src/components/input/advanced_button_compon…
f768629 
…ent.dart

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@denisgl7 @spydon
Update packages/flame/lib/src/components/input/advanced_button_compon…
0391a5d 
…ent.dart

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@denisgl7
fixed
a54576a
@denisgl7
fixed
ed072f4
@denisgl7
fixed
de8035d
@denisgl7
add golden test to advanced button
4c7b8a8
@denisgl7
add golden test to advanced button
d1391d2
@denisgl7
add golden test to advanced button
16a47b5
@denisgl7
add golden test to advanced button
0120128
@denisgl7
add golden test to advanced button
6fa7283
@denisgl7
add golden test to advanced button
7ef1b10
spydon
spydon approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Lgtm (except the minor change with the golden test)

packages/flame/test/components/advanced_button_component_test.dart Show resolved Hide resolved
@denisgl7 denisgl7 force-pushed the add_advanced_button_component branch from afd6e57 to fde43a6 Compare October 10, 2023 06:13
@spydon spydon merged commit 97fff0e into flame-engine:main Oct 10, 2023
8 checks passed
@denisgl7 denisgl7 deleted the add_advanced_button_component branch October 31, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@erickzanardo erickzanardo erickzanardo left review comments

@luanpotter luanpotter luanpotter left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@denisgl7 @spydon @erickzanardo @luanpotter