Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add necessary generics on mixins on FlameGame #2763

Merged
merged 5 commits into from Sep 22, 2023
Merged

fix: Add necessary generics on mixins on FlameGame #2763

merged 5 commits into from Sep 22, 2023

Conversation

spydon
Copy link
Member

@spydon spydon commented Sep 22, 2023 •
edited

Description

Since FlameGame now takes in W extends World the mixins that are on FlameGame needs to be able to take in the same generics.

Later the HasKeyboardHandlerComponents wont be necessary, but let's do this intermediary step.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

Closes #2761

@spydon spydon enabled auto-merge (squash) September 22, 2023 13:59
@spydon spydon enabled auto-merge (squash) September 22, 2023 14:01
@spydon spydon merged commit b1f5ff2 into main Sep 22, 2023
7 checks passed
@spydon spydon deleted the spydon/generics-on-mixins branch September 22, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flame mixins ... on FlameGame require a generic type to be useable.
2 participants
@spydon @erickzanardo