Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Duration in LottieRenderer rounds down milliseconds #2808

Merged
merged 2 commits into from
Oct 10, 2023
Merged

fix: Duration in LottieRenderer rounds down milliseconds #2808

merged 2 commits into from
Oct 10, 2023

Conversation

BingXuanBaka
Copy link
Contributor

Description

Duration in LottieRenderer rounds down milliseconds and causes two problems:

  • Speeds up when rendering a Lottie animation that duration is non-integer seconds.
  • When rendering Lottie animation that duration shorter than one second, duration of the animation will detect as zero seconds and cause the hole game freeze at a single frame.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

spydon
spydon approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for your contribution

@spydon spydon enabled auto-merge (squash) October 10, 2023 12:20
@spydon spydon merged commit cccae2e into flame-engine:main Oct 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BingXuanBaka @spydon