Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flame_tiled): Allowing tilesets with images in the same folder to load #2814

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

erickzanardo
Copy link
Member

Description

Before, when trying to use tilesets where their images were stored in the same folder as their tsx were, the loading would break.

This PR addresses that.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@erickzanardo erickzanardo requested a review from a team October 11, 2023 14:59
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, lgtm!

@erickzanardo
Copy link
Member Author

@spydon I've updated one of the goldens. I was curious on why it changed, because in theory, what I changed, shouldn't produce different goldens. Here is a screenshoot comparing both goldens:

Screenshot 2023-10-11 at 14 05 17

After debugging, I reliazed that this probably changed because since I map some paths, the order in which images are written in the atlas is different, which generates a different packing, IMO, this isn't an issue, since all the images are still there, so I just updated the golden. But let me know if you agree with that

@spydon spydon merged commit 3b0d7e6 into main Oct 12, 2023
8 checks passed
@spydon spydon deleted the feat/allow-tsx-images-in-the-same-level branch October 12, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants