feat: Expose addition test arguments on flame test #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzanardo
changed the title
spydon
approved these changes
Oct 31, 2023
Comment on lines
+31
to
+32
| dynamic tags, | ||
| dynamic skip, |
There was a problem hiding this comment.
Suggested change
| dynamic tags, | |
| dynamic skip, | |
| Object? tags, | |
| Object? skip, |
There was a problem hiding this comment.
Shouldn't we match the api from test?
There was a problem hiding this comment.
They just have it as dynamic for legacy reasons, but we could, doesn't matter that much.
There was a problem hiding this comment.
got ya, I slightly feel we would rather keep matching their apis. Gonna go with as is right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were a few arguments in
testthat wasn't being exposed bytestWithGameandtestWithFlameGame.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Replace or remove this text.