Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Make Viewfinder and Viewport comply with CoordinateTransform interface #2872

Merged
merged 3 commits into from Nov 26, 2023

Conversation

luanpotter
Copy link
Member

Description

Make Viewfinder and Viewport comply with CoordinateTransform interface; they already perform the coordinate transform operation but didn't technically implement then interface.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gltm!

@spydon spydon enabled auto-merge (squash) November 26, 2023 17:14
@luanpotter luanpotter force-pushed the luan.spydon.viewfinder-viewport-coords branch from c8cee1d to 4b442da Compare November 26, 2023 17:22
@luanpotter luanpotter changed the title feat: Make Viewfinder and Viewport comply with CoordinateTransform interface docs: Make Viewfinder and Viewport comply with CoordinateTransform interface Nov 26, 2023
@spydon spydon merged commit 685e1d9 into main Nov 26, 2023
8 checks passed
@spydon spydon deleted the luan.spydon.viewfinder-viewport-coords branch November 26, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants