New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Scrollable TextBoxComponent #2901
Conversation
add ScrollTextBox docs fixes ScrollTextBox bugs exports ScrollTextBox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments, overall it looks good!
packages/flame/lib/src/components/scroll_text_box_component.dart
Outdated
Show resolved
Hide resolved
packages/flame/lib/src/components/scroll_text_box_component.dart
Outdated
Show resolved
Hide resolved
packages/flame/lib/src/components/scroll_text_box_component.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the comments weren't resolved properly
packages/flame/lib/src/components/scroll_text_box_component.dart
Outdated
Show resolved
Hide resolved
packages/flame/lib/src/components/scroll_text_box_component.dart
Outdated
Show resolved
Hide resolved
packages/flame/lib/src/components/scroll_text_box_component.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! (Fixed up the last things)
Description
This PR introduces a new ScrollTextBoxComponent, enhancing the existing text box functionalities with scrollable text capabilities. This component, built on top of the existing TextBoxComponent, is designed to handle scrollable text, thereby providing a better user interface for games that require displaying longer text content.
Added docs and and an example.
Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues