Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding ability for a SpawnComponent to not auto start #2947

Merged
merged 2 commits into from Dec 21, 2023

Conversation

erickzanardo
Copy link
Member

Description

SpawnComponent didn't had the ability to not auto start. This PR adds a new attribute in order to customize that.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Replace or remove this text.

@erickzanardo erickzanardo requested review from spydon and a team December 21, 2023 19:03
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Just a minor suggestion

packages/flame/lib/src/components/spawn_component.dart Outdated Show resolved Hide resolved
packages/flame/lib/src/components/spawn_component.dart Outdated Show resolved Hide resolved
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
@spydon spydon enabled auto-merge (squash) December 21, 2023 19:53
@spydon spydon merged commit 37c7a07 into main Dec 21, 2023
7 of 8 checks passed
@spydon spydon deleted the feat/spawn-component-auto-start branch December 21, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants