refactor!: Remove the Projector interface that is no longer used for coordinate transformations #2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coordinate transformations
luanpotter
force-pushed
the
luan.projector-is-dead
branch
from
f55a9b5
to
7a9a593
Compare
luanpotter
commented
Jan 1, 2024
| @@ -34,5 +34,3 @@ tappable | |||
| tappables | |||
| toolset | |||
| underutilize | |||
| unproject | |||
| unscale | |||
There was a problem hiding this comment.
my advanced spell check linter with unused validation is working 😌
spydon
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the Projector interface that is no longer used for coordinate transformations.
While this is exposed to end-users there is not much point in doing so as it was always an internal detail of our implementation.
Since our last batch of removals of the old event system, this was left orphaned.
I don't think deprecation is necessary as it is very unlikely that anyone is using this interface (and if they are, they can easily declare their own as we do not care about it anywhere).
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Migration instructions
This interface is no longer necessary to interop with Flame in any way shape or form.
If you wish to use it internally in your game you can just declare it yourself.