Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TexturePacker atlas can be generated from device's file #3006

Merged
merged 24 commits into from Jan 29, 2024

Conversation

gnarhard
Copy link
Contributor

Description

TexturePacker atlas can be generated from device's file.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@gnarhard gnarhard changed the title TexturePacker atlas can be generated from device's file feat: TexturePacker atlas can be generated from device's file Jan 26, 2024
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm!
Rotations were not supported in here, right?

@gnarhard
Copy link
Contributor Author

The data to rotate the image or not is still getting set when we parse through the atlas and build a list of TexturePackerSprites. Within the TexturePackerSprite class, I ripped out the render method and anything related to actually performing a rotation.

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@spydon spydon merged commit 4e6968a into flame-engine:main Jan 29, 2024
8 checks passed
@gnarhard gnarhard deleted the flame_texturepacker branch January 29, 2024 17:48
@gnarhard gnarhard restored the flame_texturepacker branch January 29, 2024 17:48
@gnarhard gnarhard deleted the flame_texturepacker branch January 29, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants