Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use camera argument name in Forge2DGame #3115

Merged
merged 1 commit into from Apr 4, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Apr 4, 2024

Description

Since the old camera now is completely removed, to be consistent with FlameGame the Forge2DGame should also name it's camera argument camera.

Fixes #3114

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

Copy link
Collaborator

@ufrshubham ufrshubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Now I'll have to re-record some parts of my upcoming video 🥲

@spydon spydon merged commit 9d97b12 into main Apr 4, 2024
8 checks passed
@spydon spydon deleted the fix/forge2d-game-camera-argument branch April 4, 2024 19:58
@domesticmouse
Copy link
Contributor

Any ideas on when this will hit production? My CI will catch it anyway, but it'd be nice to have the right thing in the published codelab for a lil while at least =)

@ufrshubham
Copy link
Collaborator

ufrshubham commented Apr 5, 2024

Any ideas on when this will hit production? My CI will catch it anyway, but it'd be nice to have the right thing in the published codelab for a lil while at least =)

This is not a breaking change right now. So even if it is released it shouldn't break anything for a while. Most probably users will just see a deprecation warning until it is completely removed.

@spydon
Copy link
Member Author

spydon commented Apr 5, 2024

Any ideas on when this will hit production? My CI will catch it anyway, but it'd be nice to have the right thing in the published codelab for a lil while at least =)

Just released flame_forge2d v0.18.0 :)
If you know anyone at Google to poke to get them to look at my design doc for how to do semi-automatic releases, this process would be a lot less cumbersome. 😄
dart-lang/pub-dev#7177 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Forge2DGame's cameraComponent constructor parameter to camera for consistency with FlameGame
3 participants