Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add accessor to determine a TextElement size #3130

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Conversation

luanpotter
Copy link
Member

@luanpotter luanpotter commented Apr 18, 2024

Description

Add accessor to determine a TextElement size.

Currently, there is no way to figure out the actual size of a TextElement.

This is quite important as the element will have the lines laid out and broken down, so we need a way to determine the height of the resulting bounding box.

Before:

After:

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter marked this pull request as ready for review April 18, 2024 14:40
@luanpotter luanpotter merged commit 8a63a07 into main Apr 18, 2024
8 checks passed
@luanpotter luanpotter deleted the luan.element-box branch April 18, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants