Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expand flame_lint to respect required pub.dev checks #3139

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

luanpotter
Copy link
Member

Description

Expand flame_lint to respect required pub.dev checks.

We are currently losing pub points due to lint violations:

image

Turns out flame_lint does not respect lints/core which is being enforced now by pub.

This adds that as a dependency on flame_lint, updates flutter_lint for the packages that use that, and fix all existing violations (luckily very few).

This change will ensure that us and everyone else who uses flame_lint get all the points they deserve on pub. We can consider expanding to lints/recommended in the future, but that is definitely not a requirement at this stage (and a much bigger change).

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter marked this pull request as ready for review April 27, 2024 21:33
@luanpotter luanpotter requested a review from spydon April 28, 2024 14:15
@luanpotter luanpotter merged commit 6e80bf5 into main Apr 28, 2024
8 checks passed
@luanpotter luanpotter deleted the luan.lint.3 branch April 28, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants