Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Properly use the getX/YAxis out vector #61

Merged
merged 3 commits into from Aug 22, 2022
Merged

fix: Properly use the getX/YAxis out vector #61

merged 3 commits into from Aug 22, 2022

Conversation

spydon
Copy link
Member

@spydon spydon commented Jul 18, 2022

Description

Previously a vector was sent in to the methods, but it wasn't used.
This PR makes that vector optional and makes use of it.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change, doubt that anyone is using this class manually though.

Related Issues

Closes #60

@spydon spydon requested a review from a team July 18, 2022 19:34
@spydon spydon enabled auto-merge (squash) August 22, 2022 19:26
@spydon spydon merged commit c1aba67 into main Aug 22, 2022
@spydon spydon deleted the spydon/rot-axis-out branch August 22, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused method arguments in Rot. Can it be removed?
2 participants
@spydon @erickzanardo