Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: isEnabled getter and setter #65

Merged
merged 13 commits into from Aug 26, 2022

Conversation

alestiago
Copy link
Collaborator

@alestiago alestiago commented Jul 21, 2022

Description

Removed setEnabled and isEnabled. Also updated documentation for the new getter and setter.

// Before:
contact.setEnabled(true);
contact.isEnabled(); // true

// After:
contact.isEnabled = true;
contact.isEnabled; // true

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@alestiago alestiago requested a review from spydon August 24, 2022 22:08
@spydon spydon enabled auto-merge (squash) August 26, 2022 08:50
auto-merge was automatically disabled August 26, 2022 08:56

Head branch was pushed to by a user without write access

@spydon spydon changed the title refactor!: enabled getter and setter refactor!: isEnabled getter and setter Aug 26, 2022
@spydon spydon merged commit 839e53a into flame-engine:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants