Skip to content
This repository has been archived by the owner on Mar 27, 2022. It is now read-only.

Issue #12: requested changes #18

Merged
merged 7 commits into from Jul 28, 2020
Merged

Conversation

azack
Copy link
Contributor

@azack azack commented Jul 27, 2020

Resolves #12

This is a fork of the PR from #16 with the requested changes. I also ran into the underlying issue of #12 and didn't want the PR to get too stale.

Warning though, I'm having some issues verifying the changes due, I think, to the age of some of the settings in these projects (earlier sdks and gradle versions and androidx fun), so consider this untested.

Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luanpotter luanpotter merged commit cb4b5aa into flame-engine:master Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled Exception: PlatformException(error, The new embedding does not support the old FlutterView., null)
3 participants