Spacing field in tmx file is not working

[Jcupzz]

The above tiles image in Tiled Map Editor with spacing = "1" is working fine. But when it comes to flame_tiled its not working.
The output I get is the below image with those yellow lines which are from the tile image above.

I am just a noob and I don't know if this occurs due to my code. Also, in the example file of flame_tiled repo the image doesn't have those yellow grid lines.

The tmx file can be found in the repo attached below.
Please run this game for further reference
https://github.com/Jcupzz/Super-Mario.git

[luanpotter]

I think we dont have any example using that field, so it's very likely broken. I will test this against the new flame_tiled

[Jcupzz]

I think we dont have any example using that field, so it's very likely broken. I will test this against the new flame_tiled

Ok cool!

[Hwan-seok]

Any news?

[spydon]

Any news?

No news, if anyone want to take on this feel free! :)

[natebot13]

tiled.dart/lib/src/tileset/tileset.dart

Lines 212 to 213 in dece94d

	(tileWidth! + spacing).toDouble(),
	(tileHeight! + spacing).toDouble(),

This is the reason. Spacing shouldn't be added to the source rectangle. Removing the spacing fixes the issue.

[spydon]

tiled.dart/lib/src/tileset/tileset.dart

Lines 212 to 213 in dece94d

	(tileWidth! + spacing).toDouble(),
	(tileHeight! + spacing).toDouble(),

This is the reason. Spacing shouldn't be added to the source rectangle. Removing the spacing fixes the issue.

Do you want to put up a PR for the fix? :)

[ufrshubham]

I see a PR is open for this but it is not approved. Is that not the correct fix for this issue?

[spydon]

I see a PR is open for this but it is not approved. Is that not the correct fix for this issue?

I think it was just forgotten. Would be good if someone depended on the branch and tried the fix.

[ufrshubham]

@spydon I just tried to test that branch but the problem still persists. After debugging I found out that it was failing because spacing and margin parameters were not copied in _checkIfExtenalTsx() method.

Edit: This is required only for cases where an external tileset file is used. For embedded tilesets, original fix should be enough.

[natebot13]

@ufrshubham interesting, I'm willing to take a look later today.

[natebot13]

This has been fixed with pull request #41 and I believe has been verified by @ufrshubham

[ufrshubham]

This has been fixed with pull request #41 and I believe has been verified by @ufrshubham

Yes, I've tested that PR and it works.