Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: support parsing empty tile terrain values #61

Merged
merged 1 commit into from Oct 31, 2022

Conversation

devoncarew
Copy link
Contributor

@devoncarew devoncarew commented Oct 30, 2022

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Copy link
Collaborator

@kurtome kurtome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think title should be "fix!" since it's a breaking change

@devoncarew
Copy link
Contributor Author

LGTM, but I think title should be "fix!" since it's a breaking change

Ah, because of the type change from Tile List<int> terrain to List<int?> terrain? I suppose that would be - people using that API would see CI failures until they updated to handle nullable elements. I'll update the PR title and checkboxes. I'm not sure about the process wrt updating the changelog and pubspec versions.

@devoncarew devoncarew changed the title fix: support parsing empty tile terrain values fix! support parsing empty tile terrain values Oct 31, 2022
@devoncarew devoncarew changed the title fix! support parsing empty tile terrain values fix!: support parsing empty tile terrain values Oct 31, 2022
@kurtome
Copy link
Collaborator

kurtome commented Oct 31, 2022

I'm not sure about the process wrt updating the changelog and pubspec versions.

melos will do that automatically next time we cut a release based on the PR titles. We decided recently to try to get all the breaking changes in now before we get to v1.0, so it's good timing 👍

@spydon spydon merged commit 3c75b03 into flame-engine:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormatException when parsing a tmx file
3 participants