Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Omit TiledImage without source from TiledMap.tiledImages #68

Merged
merged 2 commits into from Mar 28, 2023
Merged

feat: Omit TiledImage without source from TiledMap.tiledImages #68

merged 2 commits into from Mar 28, 2023

Conversation

Hwan-seok
Copy link
Contributor

Description

  • TiledMap.tiledImages returned TiledImage even if the source is null but now it returns only images with the source.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Closes #67

@spydon spydon merged commit 41c9439 into flame-engine:main Mar 28, 2023
5 checks passed
@Hwan-seok Hwan-seok deleted the hwanseok.tiled-images branch March 28, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[proposal] Omit empty TiledImage from TiledMap.tiledImages
2 participants
@Hwan-seok @spydon