Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for screen recording #2201

Closed
godalming123 opened this issue Dec 29, 2021 · 7 comments
Closed

No support for screen recording #2201

godalming123 opened this issue Dec 29, 2021 · 7 comments
Labels
Duplicate This issue/PR is duplicated and the duplicated issue/PR is commented. Enhancement Feature requests and code enhancements Plugin Issues related to plugins and API system

Comments

@godalming123
Copy link

Feature Description

I think it would be nice if flameshot could take small screen recordings nothing fancy just say a 60 second capture that can be shown in you tray or a permenant capture that can also be shown and paused or saved from your tray.

@godalming123 godalming123 added the Enhancement Feature requests and code enhancements label Dec 29, 2021
@mmahmoudian
Copy link
Member

mmahmoudian commented Dec 29, 2021

I think that is out of the scope of Flameshot. There are already very good software (e.g peek) that you can use. Perhaps reinventing the wheel is not good at this point.

I'll keep this open and tag the following devs to know their opinion and then we can close it if everyone share the same opinion with me.

@borgmanJeremy @veracioux @ZetaoYang @hosiet @ThePurple @Martin-Eckleben

@panpuchkov
Copy link
Contributor

I think that it's out of scope now. I had such requests too, but current concept is far from video recording.
I think that the only possible option is to integrate some 3rd-party screen recording tool and to call it transparently from the Flameshot. But it will be a challenge to find and support a good cross-platform tool with ability to integrate it.

@holazt
Copy link
Collaborator

holazt commented Dec 29, 2021

The core function of flameshot is to take a screenshot and draw it, then save or copy it to the clipboard. However, flameshot still needs to work on this core feature, such as non-integer scaling for high resolution screens, multiple monitors, and wayland environments, which does not work well. Besides, the drawing function, also need a lot of improvement.

Other than the above functions are non-core functions, such as uploading screenshots to imgur, and I think these non-core features can be ported to plugins. Maybe "screen recording" can be achieved in flameshot plugins.

I think some of the buttons that appear in the screenshot area could be made available as plugins, for example, upload screenshot to imgur, pin, open screenshot in application...

@mmahmoudian
Copy link
Member

I agree with both points so far. Flameshot can get feature rich through plugins and the core can be/should get more stable and light weight. There is a narrow but perhaps a fine line that should be drawn and defined by devs. I personally am not a C++ developer and therefore I'll try to minimise my influence/voice in this context as more knowledgeable fellows are onboard 🤓

@godalming123
Copy link
Author

I would agree I just didn't realise that there was simple alternatives to get the job done and flameshot defenately needs some more important features such as being able to copy the selected color as seen in flameshot 11

@veracioux
Copy link
Contributor

@mmahmoudian

I think that is out of the scope of Flameshot. There are already very good software (e.g peek) that you can use. Perhaps reinventing the wheel is not good at this point.

Absolutely agree. Flameshot should not be a screen recorder. Except in plugins, where all cards are on the table.

@borgmanJeremy
Copy link
Contributor

This is also a duplicate of #172

@mmahmoudian mmahmoudian added the Duplicate This issue/PR is duplicated and the duplicated issue/PR is commented. label Dec 30, 2021
@mmahmoudian mmahmoudian added the Plugin Issues related to plugins and API system label Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate This issue/PR is duplicated and the duplicated issue/PR is commented. Enhancement Feature requests and code enhancements Plugin Issues related to plugins and API system
Projects
None yet
Development

No branches or pull requests

6 participants