Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui + Hidpi design improvements #53

Open
axelmeunier opened this issue Jan 5, 2018 · 12 comments
Open

gui + Hidpi design improvements #53

axelmeunier opened this issue Jan 5, 2018 · 12 comments
Labels
Bug It's a bug Enhancement Feature requests and code enhancements

Comments

@axelmeunier
Copy link

axelmeunier commented Jan 5, 2018

Just tested flameshot as a possible replacement for shutter.
concerning the features they are very much enough for me, apart from delay before capture as already mentioned by another user.
I love the ability to open directly with inkscape.

But being on Gnome + having a hidpi screen, the usability is greatly hindered.
The buttons are really tiny and the info regarding the screenshot size is not readable.
The GUI (at least on a GTK DE) is very rough right now.
This app could really be superb.
capture d ecran de 2018-01-05 11-56-12

capture d ecran de 2018-01-05  #11-52-15

@lupoDharkael lupoDharkael added the Enhancement Feature requests and code enhancements label Jan 5, 2018
@lupoDharkael
Copy link
Collaborator

The "Open With" widget seems to have a problem as it should show the icons of every app.
I haven't tested Flameshot in hidpi screens as I don't own one myself but this really needs a fix.
I'm having exams soon but I'll be solving this when I have time.
I will need someone to test the fixes.

@lupoDharkael lupoDharkael added the Bug It's a bug label Jan 5, 2018
@axelmeunier
Copy link
Author

axelmeunier commented Jan 5, 2018

Ping me if you need to test hidpi fixes.
Good luck for the exams

@holazt
Copy link
Collaborator

holazt commented Jan 21, 2018

Qt does not support HiDPI scaling until 5.6. You can try to use the environment variable QT_SCALE_FACTOR=2 to run flameshot scaled. Further you can use QT_AUTO_SCREEN_SCALE_FACTOR=1 to enable automatic scaling, based on the pixel density of the monitor.
Reference https://albertlauncher.github.io/docs/faq/

@lupoDharkael
Copy link
Collaborator

lupoDharkael commented Jan 21, 2018

The problem here are the hardcoded sizes for the custom widgets. I've done some work to make it scale but it's not finished yet. @axelmeunier Could you test if the size of the icons inside the buttons look natural?

@greys
Copy link

greys commented Mar 30, 2019

@lupoDharkael hi, is this (or similar) HiDPI support being worked on? I can't seem to control scaling with QT_SCALE_FACTOR at all in my Gnome-based setup...

Please let me know if any testing needs to be done - would like to help

@KAMiKAZOW
Copy link

On Plasma the icons are very pixelated on HiDPI.

Screenshot_20200223_230340

cc @guoyunhe

@dobreo
Copy link

dobreo commented Jan 21, 2021

On Plasma the icons are very pixelated on HiDPI.

Screenshot_20200223_230340

cc @guoyunhe

i have same problem
but i see one thing - in first run app icons was nice
but after icons gona pixelated
and also my screen setting set to 150% zoom

@Zeioth
Copy link

Zeioth commented Sep 22, 2021

@ZetaoYang you may be aware of this already, but QT_SCALE_FACTOR=2 and similar only work launhcing flameshot as 'flameshot'.

If you use

'flameshot gui'

to launch the program, the env vars are entirely ignored.

Should I open an issue?

@mmahmoudian
Copy link
Member

@Zeioth I tried on Manjaro KDE plasma based on the KDE user manual and rebooted the computer after that (logging out was suffice but I wanted to leave nothing to chance). I could not reproduce it. Regardless of either of the following approaches, all the icons were with the same scale:

  • flameshot and then clicking on the tray icon
  • flameshot gui

@va-it
Copy link

va-it commented Oct 13, 2021

I had a similar problem on Ubuntu 20.04 with scaling set to 200%. If the application was opened any time after the OS had started, then all was well. But when starting flameshot on startup, then the icons during capture, the configuration panel etc. were really small. I have fixed the problem by using this command in the Startup Application Preferences app: bash -c "sleep 5 && flameshot"

@mmahmoudian
Copy link
Member

@va-it it seems the scaling on your Ubuntu (assuming it is Gnome?) happens way after the startup programs are started (which is weird to me as logically they should start after the window manager is fully loaded).

@tuananh
Copy link

tuananh commented Sep 14, 2023

QT_SCALE_FACTOR=2 works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug It's a bug Enhancement Feature requests and code enhancements
Projects
None yet
Development

No branches or pull requests

10 participants