add 闭环 #47
Merged
add 闭环 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
flaneur2020
commented
Apr 24, 2021
•
flaneur2020
commented
- add token about the 闭环 and lexer
- add parser about the 闭环 statement
- refactor: take reference instead of move on iterating the ast nodes
- add the interpreter logic about the 闭环 statement
- support 破圈(break) statement (maybe we could implement it in another PR)
chenhengqi
reviewed
Apr 24, 2021
src/evaluator/mod.rs
Outdated
| None => return None, | ||
| }; | ||
|
|
||
| while Self::is_truthy(cond.clone()) { |
There was a problem hiding this comment.
I am confused about this logic, cond is immutable, so we have an infinite loop when it evaluates to true, right ?
There was a problem hiding this comment.
yeah it's a bug, maybe it'd been fixed on my latest commit
|
BTW, please add some unit tests for this feature. |
thank your for remind, i've add some test cases about this, please check again 🤝 |
|
LGTM |
Artoria2e5
reviewed
Apr 25, 2021
| @@ -321,13 +325,35 @@ impl Evaluator { | |||
| } | |||
| } | |||
|
|
|||
| fn eval_call_expr(&mut self, func: Box<Expr>, args: Vec<Expr>) -> Object { | |||
| fn eval_while_expr( | |||
There was a problem hiding this comment.
解 Box 好啊！clippy 总跟我叨叨。
Artoria2e5
approved these changes
Apr 25, 2021
Closed
chenhengqi
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.