New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use control-flow interface in ArrayValueCopy pass #1275

Open

kiranchandramohan opened this issue Nov 26, 2021 · 0 comments

Projects

Post upstream Work

Collaborator

kiranchandramohan commented Nov 26, 2021

In general all the special casing for the Loop, branches, and the control flow in general should be handled with the ControlFlowInterface: https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Interfaces/ControlFlowInterfaces.td

This would make the code entirely uniform, and any new op that has to do with the control flow would not require to modify the pass.

Comment in https://reviews.llvm.org/D111337

kiranchandramohan created this issue from a note in Post upstream Work (todo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment