Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Run kubernetes hooks with Synchronization event right after onStartup hooks #62

Closed
diafour opened this issue Nov 6, 2019 · 1 comment
Closed

Fix: Run kubernetes hooks with Synchronization event right after onStartup hooks #62

diafour opened this issue Nov 6, 2019 · 1 comment
Milestone
1.0.0-beta.6

Comments

@diafour
Copy link
Contributor

diafour commented Nov 6, 2019

Relates to changes made for #42 and #41.

Right now kubernetes hooks will run after discovery all modules. But Synchronization event is useful for discovery information that is needed by modules.

EnableGlobalHooks method should return a set of tasks that will be queued after onStartup hooks.
@diafour diafour added this to the 1.0.0-beta.6 milestone Dec 4, 2019
@diafour
Copy link
Contributor Author

diafour commented Dec 4, 2019

Fixed in shell-operator and here in #64

@diafour diafour closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-beta.6
Development

No branches or pull requests
1 participant
@diafour