Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart: Clickhouse should be managed by StatefulSet instead of Deployment #118

Closed
dragonsmith opened this issue Dec 9, 2018 · 2 comments
Closed

Helm chart: Clickhouse should be managed by StatefulSet instead of Deployment #118

dragonsmith opened this issue Dec 9, 2018 · 2 comments
Milestone
0.3.0

Comments

@dragonsmith
Copy link

Hello!

Thanks a lot for such a big contribution to the K8s community!

I'm trying your Loghouse right now and I find the following strange: ClickHouse is a stateful app, yet, you manage it with a Deployment in your Helm chart.

I can provide a PR to fix that, what do you think?

Thank you!
@dmgtn
Copy link
Member

dmgtn commented Dec 10, 2018

Yea, you are entirely right. We are misusing deployment. PR with the fix for that will be well appreciated. The hardest part, like always, is to find the proper upgrade way.

Speaking about the future, we hope that at some time there will be Clickhouse operator and we will rely on it.

@diafour diafour added this to the 0.3.0 milestone Mar 23, 2020
@diafour
Copy link
Contributor

diafour commented Mar 23, 2020

Done in #137, released as v0.3.0.

@diafour diafour closed this as completed Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
3 participants
@dragonsmith @diafour @dmgtn