Request: Make use of environmental variables in docker-compose.yaml #76
Labels
enhancement
New feature or request
help wanted
Extra attention is needed
wontfix
This will not be worked on
Milestone
Using environmental variables will allow users to pull this git without having to reconfigure their settings. An .env file can be used to store these settings.
https://docs.docker.com/compose/environment-variables/
Proposed changes:
The environmental variables can be documented and edited in the .env file. It allows users more flexibility to how they organize and deploy the openvpn-server. For instance, I don't like that the volumes are in the same directory that the git clone is in, so I'd prefer to have a structure like:
Having a flat configuration file that's outside of the git repo directory allows users to more easily pull changes without having to manually edit the docker-compose.yaml. An adjusted start.sh could take the path to the .env file, add any missing variables and alert users of important changes.
I'd be more than happy to do a pull request with these proposed changes, though I'm by no means an expert in either docker, bash or git.
The text was updated successfully, but these errors were encountered: