This repository has been archived by the owner on May 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
on version strings for debian packages #22
Labels
Comments
👍 |
omnibus won't let me have ~ in the version string as it uses git to cache builds and tries to make a tag name including the ~, which don't work. the error:
raw output:
|
Hmm, I wonder if it's possible to escape the string being passed for the tag, and if omnibus would accept a patch for doing so? |
Yeah i was thinking of doing something similar. |
|
It might need to be a simple-minded character substitution, or removal |
reversed tilde works (∽) - U+223d - http://www.fileformat.info/info/unicode/char/223d/index.htm
|
~ working now with current omnibus master. deb created like so:
deb installs like so:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In the omnibus3 branch we've changed the flapjack software definition so that it pulls flapjack from github, rather than from rubygems.org. This has the advantage that we can now build flapjack packages from master, or any tag, without having to first publish the tagged version on rubygems.org.
But the version identifier needs some changes. Here's some points identified when discussing this with @Hobbsee, @ali-graham:
VERSION[~VERSIONMOD][~TIMESTAMP-SHA1]-DEBIAN_REVISION
~
before the first alpha char, eg tagv1.0.0rc3
=>1.0.0~rc3
- this is so the release candidate sorts earlier than the full release of1.0.0
(so that installing 1.0.0 over the top of 1.0.0rc3 would work)~TIMESTAMP-SHA1
should be included when building from a branch name or commit sha1. It's not to be included when building from a tag. The SHA1 part is the first 7 chars of the SHA-1 hash of the commit being built fromI think this is going to require a wrapper script in omnibus-flapjack that calculates the version string to use, and then runs the docker build command with it set up in env vars:
eg:
The flapjack version string can be retrieved by the wrapper script like so:
ruby -e 'load "lib/flapjack/version.rb" ; puts Flapjack::VERSION'
The text was updated successfully, but these errors were encountered: