Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish macOS artifact / executable with the release #63

Open
ngosang opened this issue Jan 8, 2021 · 9 comments
Open

Publish macOS artifact / executable with the release #63

ngosang opened this issue Jan 8, 2021 · 9 comments
Labels
CI/CD enhancement New feature or request help wanted Extra attention is needed

Comments

@ngosang
Copy link
Member

ngosang commented Jan 8, 2021

Most of the job is already done in ngosang@27ad58b

The code to build the macOS executable is commented but I need a volunteer to test it. I don't have access to a Mac.

Related #18

@ngosang ngosang added enhancement New feature or request help wanted Extra attention is needed CI/CD labels Jan 8, 2021
@Colorado4Wheeler
Copy link

I'll volunteer, I have multiple Macs and multiple Mac VM's to test it on.

@ngosang
Copy link
Member Author

ngosang commented Mar 24, 2021

@XxUnkn0wnxX @Colorado4Wheeler maybe you can help me. I don't have macOS experience.

The idea is to publish a .zip file which contains flaresolverr + chrome binaries so you don't have to install anything. Just extract and run. We are already doing that for Linux and Windows => https://github.com/FlareSolverr/FlareSolverr/releases/tag/v1.2.3

The code to generate the build is already in place but I can't test it.

          npm install
          npm run build
          npm run package
  • test the executable inside macos zip

PRs are welcome. Thank you!

Related => #99

@DarrenPIngram
Copy link

How is the Mac executable plan going? I've had problems installing via the CLI per the given instructions, and this is a bit outside of my area.

di@MacPro Flaresolver % npm run build
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /Users/di/Flaresolver/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/Users/di/Flaresolver/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

npm ERR! A complete log of this run can be found in:
npm ERR! /Users/di/.npm/_logs/2021-05-25T10_38_01_388Z-debug.log

di@MacPro Flaresolver % npm start
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /Users/di/Flaresolver/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/Users/di/Flaresolver/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

@ngosang
Copy link
Member Author

ngosang commented May 26, 2021

@DarrenPIngram I would like to provide a macOS binary but I don't have access to the hardware. Could you try this and tell me if it works?
#63 (comment)

@Colorado4Wheeler
Copy link

@ngosang you could always spin up a virtual. If needed I could host a virtual for you to play with.

@DarrenPIngram
Copy link

I could give it a tentative go (there was no attachment) but you may get better feedback if you use Colorado4Wheeler's kind offer? Ot both!

@ngosang ngosang added this to the 1.3.0 milestone May 28, 2021
@ngosang
Copy link
Member Author

ngosang commented May 28, 2021

I will take a look with a VM.

@ngosang ngosang modified the milestones: 1.2.6, 1.3.0 May 30, 2021
@bubez81
Copy link

bubez81 commented Oct 4, 2021

Hello, if you want I can try, I'm on Mac....but I think the job is already done:

` ✘ michele@perlhof  ~/FlareSolverr   master ●  npm start

flaresolverr@1.2.5 start
node ./dist/index.js

2021-10-04T12:10:18.600Z INFO FlareSolverr v1.2.5
2021-10-04T12:10:18.967Z INFO Listening on http://0.0.0.0:8191`

@ngosang ngosang modified the milestones: 2.0.0, 2.1.0 Oct 17, 2021
@ngosang
Copy link
Member Author

ngosang commented Oct 20, 2021

After the changes included in FlareSolverr v2 this task has become more difficult because Firefox executable is in DMG format and there are no good tools in Linux to extract it => https://github.com/FlareSolverr/FlareSolverr/blob/master/build-binaries.js#L51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants