Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed forum notifications #1646

Closed
PeopleInside opened this issue Nov 19, 2018 · 5 comments
Closed

Missed forum notifications #1646

PeopleInside opened this issue Nov 19, 2018 · 5 comments
Labels

Comments

@PeopleInside
Copy link

PeopleInside commented Nov 19, 2018

Current Behavior
A clear and concise description of the behavior.

As user i want can choose if receive notification for all replies in a topic or just when i am mentioned.
Actually i see in Flarum the option i want: to be notified of all replies on the topic where i am but this seems is not working as expected. If the reply has not the mention i never receive notification.

Steps to Reproduce

  1. Partecipate in a topic.
  2. Click on the Following button
  3. Following option is selected ( Be notified of all replies )
  4. See error: no email and notification arrive if you are not mentioned.

Please see this: https://discuss.flarum.org/d/17605-be-notified-when-an-update-is-avaiable/4
Also here: https://discuss.flarum.org/d/17608-issues-with-composer-on-centos/11

My experience is that i miss replies because are not notified.

Expected Behavior

  1. I should decide if by default following for all replies or just when mentioned. This maybe in the profile preference
  2. If i see i am following all replies i should be notified on all replies not only when mentioned as happen now

Screenshots
If applicable, add screenshots to help explain your problem.
https://discuss.flarum.org/d/17605-be-notified-when-an-update-is-avaiable/4

Environment

  • Flarum version: Flarum Community it's your version and your forum. The bug is in the Flarum support community

  • Website URL: https://discuss.flarum.org/

Output of "php flarum info", run this in terminal in your Flarum directory.

I cannot do as server is yours :D

Possible Solution

Additional Context
In a support community you should never miss replies. In my experience with the Flarum forum i found many replies to my topics that i miss to read because of no notifications.

@PeopleInside
Copy link
Author

I understood now all replies means when someone click on reply on your message.
Should be another option to decide to be notified of all message posted in a topic. This will be not inserted in the core? There is an extension who will do that?

@tobyzerner
Copy link
Contributor

Actually, here "all replies" refers to all new posts in the discussion, even if they're not in direct reply to yours. Note that you will only receive one notification for the first new post that you haven't seen, and you won't receive any further notifications until you are once again up-to-date and have read all the posts in the discussion.

If you're not receiving this initial notification, though, that's a bug. I've followed a few discussions on discuss.flarum.org to see if I can reproduce the issue.

@tobyzerner
Copy link
Contributor

Confirmed and fixed. Thanks for the report @PeopleInside.

@PeopleInside
Copy link
Author

@tobscure i made some errors maybe but i am happy to see i can help little bit. Happy to be right this time, thank you!

@PeopleInside
Copy link
Author

PeopleInside commented Nov 27, 2018

Hi @tobscure , this is not fully fixed.

Never received a notification also for the reply up

Update: I subscribed here and when a new message has been posted i was notified. * Confused :D * maybe i experience no notification because two previous post was a direct reply to user post? This should be notified anyway...

askvortsov1 pushed a commit to flarum/subscriptions that referenced this issue Mar 11, 2022
It seems that 97a80be2954ffbdc641c09d313f552bad52d2ba0 actually caused
a regression. With the order of execution of extensions, this event
listener was always being executed before the discussion metadata
was updated, and the listener priority was not actually necessary.

Fixes flarum/framework#1646
askvortsov1 pushed a commit to flarum/subscriptions that referenced this issue May 10, 2022
It seems that c7aeef19ead13a9804adf0c00895ee66d705c91e actually caused
a regression. With the order of execution of extensions, this event
listener was always being executed before the discussion metadata
was updated, and the listener priority was not actually necessary.

Fixes flarum/framework#1646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants