Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tags] "Invalid date" displayed randomly on posts on tags page #1662

Closed
poVoq opened this issue Nov 29, 2018 · 16 comments
Closed

[Tags] "Invalid date" displayed randomly on posts on tags page #1662

poVoq opened this issue Nov 29, 2018 · 16 comments

Comments

@poVoq
Copy link

poVoq commented Nov 29, 2018

Bug Report

Current Behavior
Just installed a fresh version of Beta8 on my shared host and when posting new topics they don't show up in the All discussions page. Only if I go to the exact sub-tag they are visible.
If I switch to the tags view the posts get added to the bottom row of the tag, but randomly a "INVALID DATE" is shown instead of the actual time it was posted.

This is on a Netcup.de shared host and Flarum Beta7 is running great on it.

The page in question is running php 7.2.12.

@franzliedke
Copy link
Contributor

Please post the output of php flarum info, as we ask for in the bug report template.

@poVoq
Copy link
Author

poVoq commented Nov 30, 2018

Seems to work better with php 7.1.24, but it still sometimes shows up as invalid date? Not sure, might be a browser caching issue?

Flarum core 0.1.0-beta.8
PHP version: 7.2.10
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, bcmath, bz2, calendar, ctype, dba, dom, hash, fileinfo, filter, ftp, gettext, SPL, iconv, session, json, mbstring, standard, Phar, posix, Reflection, imap, shmop, SimpleXML, soap, sockets, exif, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xml, xmlreader, xmlwriter, zip, mysqlnd, imagick, curl, gd, mysqli, PDO, pdo_mysql, xsl, sqlite3, intl, ionCube Loader
+----------------------+-----------------+--------+
| Flarum Extensions    |                 |        |
+----------------------+-----------------+--------+
| ID                   | Version         | Commit |
+----------------------+-----------------+--------+
| flarum-bbcode        | v0.1.0-beta.8   |        |
| flarum-emoji         | v0.1.0-beta.8   |        |
| flarum-lang-english  | v0.1.0-beta.8   |        |
| flarum-flags         | v0.1.0-beta.8   |        |
| flarum-likes         | v0.1.0-beta.8   |        |
| flarum-lock          | v0.1.0-beta.8   |        |
| flarum-markdown      | v0.1.0-beta.8   |        |
| flarum-mentions      | v0.1.0-beta.8   |        |
| flarum-statistics    | v0.1.0-beta.8   |        |
| flarum-sticky        | v0.1.0-beta.8   |        |
| flarum-subscriptions | v0.1.0-beta.8   |        |
| flarum-suspend       | v0.1.0-beta.8   |        |
| flarum-tags          | v0.1.0-beta.8.1 |        |
| flarum-approval      | v0.1.0-beta.8   |        |
+----------------------+-----------------+--------+
Base URL: https://community.freegamedev.net
Installation path: /fgd_flarum/flarum
Debug mode: off

I think the wrong php version is displayed because this host uses a different php version in CLI than to actually render the website.

@tobyzerner
Copy link
Contributor

Just installed a fresh version of Beta8 on my shared host and when posting new topics they don't show up in the All discussions page. Only if I go to the exact sub-tag they are visible.

Is the "Hide from All Discussions" checkbox ticked for your tags?

The INVALID DATE issue is occurring on discuss.flarum.org too for some tags, so we can verify that one.

@tobyzerner tobyzerner changed the title Invalid date error on fresh Beta8 install [Tags] "Invalid date" displayed for some tags on tags page Nov 30, 2018
@poVoq
Copy link
Author

poVoq commented Dec 1, 2018

No the hide checkbox is not used, but it happens both on primary tags and sub tags of primary tags.

I also noticed that the default "General" tag was acting strangely (reverting color and location randomly but temporarily) but it seems that after completely removing and recreating it at least that issue was removed.

@tobyzerner
Copy link
Contributor

And what permissions do you have set up on the tags? I'm unable to reproduce that part.

@poVoq
Copy link
Author

poVoq commented Dec 1, 2018

No special permissions. This is literally a fresh installation with no special setup. I just installed and created some primary tags.

@tobyzerner
Copy link
Contributor

Mystery. Can anyone else test/confirm this?

@poVoq poVoq changed the title [Tags] "Invalid date" displayed for some tags on tags page [Tags] "Invalid date" displayed tandomly on posts on tags page Dec 1, 2018
@poVoq poVoq changed the title [Tags] "Invalid date" displayed tandomly on posts on tags page [Tags] "Invalid date" displayed randomly on posts on tags page Dec 1, 2018
@poVoq
Copy link
Author

poVoq commented Dec 1, 2018

The strange thing is that Flarum Beta7 is right now running on the same web-pack with the exact same setup just fine, but Beta8 is non-usable because the posts dont't show up in the all discussions section most of the time.

Maybe this is a database issue? This is on MySQL 5.7.24 on a separate server (not localhost).

@PeopleInside
Copy link

PeopleInside commented Dec 2, 2018

@poVoq
Copy link
Author

poVoq commented Dec 2, 2018

The difference seems to be that while this also shows up on discuss.flarum.org (both in Firefox and Chome) the posts in the "all discussions" view still seem to be unaffected? On my forum the all discussions view stays empty most of the time because of this bug.

@luceos
Copy link
Member

luceos commented Dec 4, 2018

Look at the discussions. These seem to be spam items, maybe they are visible while being held for moderation (approval extension?) or they have been deleted and as such don't have the attribute date?

@PeopleInside
Copy link

@luceos good idea but not sure.
If i click on the items with near the invalid date the post is opened than i press back button in the browser and invalid date disappears.

00 - copia
01 - copia

@luceos
Copy link
Member

luceos commented Dec 4, 2018

@PeopleInside scores!

Just confirmed the same thing, pretty easy to reproduce, try hard refreshing your /tags page. Seems like it's not using/requesting enough attributes?

@PeopleInside
Copy link

If i refresh the page in the screenshot i continue to see invalid date also if i refresh Firefox 10 times.
It change for me only if i click on the post near the invalid time than press back button to return to the tag screen. Just the post clicked has now the correct time.

I do not understand on programming side where the issue is but this is what i can see. :P Tested with Firefox and Chrome, latest version.

@poVoq
Copy link
Author

poVoq commented Dec 4, 2018

Yeah, that is one of the ways I meant with more or less randomly. Similarly you can refresh the "all discussions" page and sometimes the posts will show up. If they show up you can click on "tags" and there is no invalid date, but after a page refresh it comes back.

@PeopleInside
Copy link

PeopleInside commented Dec 4, 2018

Issue resolved, thanks to @tobscure for fixing this and @poVoq for the report :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants