Confirmation email code duplication

[matteocontrini]

Hello,

I've noticed that the SendConfirmationEmailController and AccountActivationMailer classes do almost exactly the same thing, with the only difference that they are triggered in different situations.

I think that there's space for improvement and that the code duplication could be avoided.

[clarkwinkelmann]

I'm not sure that's worth it seeing how little code there's in the Confirmation controller.

Though we could probably move some of the methods of the ActivationMailer to a trait and re-use them in both places.

[askvortsov1]

Tbh, this seems like a litle over-optimization. If we need to use that code again in a third place, then let's abstract it away. But for now, I think that might bring more confusion than justified

[matteocontrini]

Honestly I don't agree. The code in the two files literally does the same exact thing, it's just arranged slightly differently. I think this brings more confusion because there are multiples places where the confirmation email can be sent out, with the same exact configuration.

A change in the confirmation email would require modifying the same (copy-pasted) code in two places, and I don't see how this could be considered good or make sense.

EDIT: moreover, in the case of password reset the code is already extracted in a command.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!