SMTP username and password shouldn't be required

[clarkwinkelmann]

Bug Report

Current Behavior
You can't set an empty username or password for SMTP via the admin interface.

Steps to Reproduce

1. Go to Admin > Email
2. Leave username or password field blank
3. Click Save
4. Error message for field required

Expected Behavior
Some SMTP servers do not require a password and possibly not a username either. I think the library handles username-less and password-less correctly so we shouldn't require them in the interface.

Environment

• Flarum version: beta13

Output of "php flarum info", run this in terminal in your Flarum directory.

Possible Solution
Remove required rule in https://github.com/flarum/core/blob/1d7641cbb098d92f5be3f17561a0e6b52ee2c6b0/src/Mail/SmtpDriver.php

Additional Context
Follows report in https://discuss.flarum.org/d/24617-how-to-use-smtp-without-username-authentication

[phanlyhuynh]

@clarkwinkelmann Hi bro, I can fix it. Thanks!