Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General pre-stable cleanup tasks #2700

Closed
9 of 10 tasks
askvortsov1 opened this issue Mar 17, 2021 · 4 comments
Closed
9 of 10 tasks

General pre-stable cleanup tasks #2700

askvortsov1 opened this issue Mar 17, 2021 · 4 comments
Assignees
@luceos @SychO9 @askvortsov1

Comments

@askvortsov1
Copy link
Sponsor Member

askvortsov1 commented Mar 17, 2021 •
edited by luceos

  • Clean up and standardize backend docblocks
  • Clean up and standardize frontend docblocks
  • Clean up private vs protected usage
  • Add (or remove everywhere) file top comment blocks in JS
  • Make sure all extenders have methods documenting arguments, especially callback arguments.
  • Remove all beta references in installer / config / code
    • Docs
    • Core source code
    • flarum/flarum
    • The flarum website
@askvortsov1 askvortsov1 added this to the 0.1 milestone Mar 17, 2021
@askvortsov1 askvortsov1 mentioned this issue Mar 17, 2021
Closed
@askvortsov1 askvortsov1 mentioned this issue Apr 16, 2021
Closed
4 tasks
@SychO9 SychO9 mentioned this issue May 12, 2021
Merged
@davwheat
Copy link
Member

Would it be worth adding "update JS imports in bundled exts" to the list?

All the bundled exts still use flarum/components (or similar) imports rather than the forum/admin/common namespaced imports.

@askvortsov1
Copy link
Sponsor Member Author

If there's time, we should also add prettier to all exts and run their JS through that.

@luceos
Copy link
Member

luceos commented May 25, 2021

As nothing else was tackled, let's "clean up" for the upcoming 1.1 release.

@luceos luceos modified the milestones: 1.0, 1.1 May 27, 2021
@askvortsov1 askvortsov1 modified the milestones: 1.1, 1.2 Sep 28, 2021
@askvortsov1 askvortsov1 removed this from the 1.2 milestone Oct 22, 2021
@askvortsov1
Copy link
Sponsor Member Author

Closing as "cleanup" isn't actionable. Extension infra consistency somewhat falls under flarum CLI audit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luceos luceos

@SychO9 SychO9

@askvortsov1 askvortsov1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@luceos @davwheat @SychO9 @askvortsov1