Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to manually confirm a user's email address #414

Closed
JacobThaDev opened this issue Sep 2, 2015 · 6 comments · Fixed by #1093
Closed

Ability to manually confirm a user's email address #414

JacobThaDev opened this issue Sep 2, 2015 · 6 comments · Fixed by #1093

Comments

@JacobThaDev
Copy link

Someone mentioned not recieving emails for validation, and manual approval does not exist. Also needs ability to see members online, and possibly a public directory. Basically just needs full user management

@tobyzerner
Copy link
Contributor

We'll make this ticket for implementing manual approval. The rest is covered in #283.

@tobyzerner tobyzerner changed the title User Management & Approval Ability to manually confirm a user's email address Sep 4, 2015
@tobyzerner tobyzerner added this to the 0.1.0-beta.6 milestone Mar 16, 2016
@tobyzerner tobyzerner modified the milestones: 0.1.0-beta.7, 0.1.0-beta.6 Aug 23, 2016
@renyuneyun
Copy link
Contributor

renyuneyun commented Dec 23, 2016

So I've found the api/backend already contains such ability - just need to send PATCH request with data
{ 'data': {'attributes': { 'isActivated':'true' } } } (together with admin token) to FORUM_URL/api/users/:userid.

I tried to modify 'js/forum/src/components/EditUserModal.js' to add a 'activated' checkbox under the 'Email' section, but I have no idea how to reload the js in order to take effect.
In the beginning I though I need to follow https://github.com/flarum/flarum/blob/master/CONTRIBUTING.md to recompile the js, but there is still no effect (or maybe I did something wrong).

How can I see the result after changing the js files?

By the way, what's the relationship between Mithril and ES6?

@dav-is
Copy link

dav-is commented Dec 23, 2016

By the way, what's the relationship between Mithril and ES6?

Mithril at the time being doesn't use ES6. Flarum has ES6 classes to make use of mithril. Then all the rest of Flarum builds on these classes. Does this make sense?

@renyuneyun
Copy link
Contributor

Yes.
So the transpiling step is to change ES6 to a lower version (e.g. ES5?) to let it run correctly on current browsers/tools/environment?

Wouldn't the modified JS be then downloaded by the browser (after refreshing the page) after transpiling? Or are there other steps needed?

@renyuneyun
Copy link
Contributor

OK, I found that if I set 'debug' => true in config.php, the changes will take effect.
But... Why?

@dav-is
Copy link

dav-is commented Dec 24, 2016

There should a compile.sh that you'll want to run in the core files. Be sure not to commit the compiled app.js files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants