Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add titles for pages that lack them #495

Closed
dcsjapan opened this issue Sep 16, 2015 · 2 comments · Fixed by #2047
Closed

Add titles for pages that lack them #495

dcsjapan opened this issue Sep 16, 2015 · 2 comments · Fixed by #2047

Comments

@dcsjapan
Copy link
Contributor

Some pages show nothing but the forum name in the title bar. The following titles can be added:

  • "All Discussions" for the All Discussions page
  • "Tags" for the Tags page
  • The tag name when a tag-specific discussion list is displayed

In addition, a routine is needed to omit the title of whatever page is set as the site homepage.

@tobyzerner tobyzerner added this to the 0.1.0-beta.6 milestone Mar 16, 2016
@tobyzerner tobyzerner modified the milestones: 0.1.0-beta.7, 0.1.0-beta.6 Aug 23, 2016
@franzliedke franzliedke self-assigned this Feb 13, 2017
@tobyzerner tobyzerner removed this from the 0.1.0-beta.7 milestone Jul 22, 2017
@franzliedke franzliedke removed the SEO label Jul 21, 2018
@franzliedke franzliedke added this to the 0.1 milestone Dec 7, 2019
@askvortsov1
Copy link
Sponsor Member

I've added titles for the tags pages in flarum/tags#72. I'll add the "All Discussions" title, and the logic for clearing the homepage in a new PR.

@askvortsov1
Copy link
Sponsor Member

What's better than 1 pull request? 6 Pull Requests! Here we go...

  1. Added all discussions title to all discussions page, created mechanism to clear title if on defaultRoute
    Core: Add index page title, add mechanism to clear title from defaultRoute. #2047
    Lang pack: Add 'all discussions' meta title lang-english#158

  2. Add title to 'all tags' and individual tag pages:
    Tags: Added title and description meta tags tags#72
    Lang pack: Add title and description to tags and tag pages lang-english#154

  3. Add title to 'following' page:
    Subscriptions: Added meta title to following page subscriptions#23
    Lang Pack: Add meta title to following page lang-english#159

Have fun y'all!

@franzliedke franzliedke removed their assignment Jun 3, 2020
franzliedke pushed a commit to flarum/subscriptions that referenced this issue Jun 3, 2020
franzliedke pushed a commit to flarum/lang-english that referenced this issue Jun 3, 2020
@askvortsov1 askvortsov1 modified the milestones: 0.1, 0.1.0-beta.14 Jun 27, 2020
askvortsov1 added a commit to flarum/lang-english that referenced this issue Mar 11, 2022
askvortsov1 added a commit to flarum/subscriptions that referenced this issue Mar 11, 2022
askvortsov1 added a commit to flarum/lang-english that referenced this issue May 10, 2022
askvortsov1 added a commit to flarum/subscriptions that referenced this issue May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants