Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a whitelist for popular email provider weblinks #541

Closed
franzliedke opened this issue Sep 24, 2015 · 14 comments
Closed

Create a whitelist for popular email provider weblinks #541

franzliedke opened this issue Sep 24, 2015 · 14 comments

Comments

@franzliedke
Copy link
Contributor

Seeing problems like #62, #480 and #481, we may want to consider only showing the email provider link to emails where we definitely know it works (GMail, Yahoo, Hotmail/Outlook...).

If we have a list of, say, the 10 most popular email providers, we still have a ton of people enjoying this nice touch, but don't confusion with others where we don't know whether our assumption holds...

@Fastidious
Copy link

@franzliedke as I commented on one of those tickets :-) :

"Popular email providers will not cut it. It should not link to the domain of the email, it should simply redirect to forum root, after telling the user to check for email. Many users will have their own domain, corporate emails, etc., and it will not be possible to account for all."

@franzliedke
Copy link
Contributor Author

Of course we can't do it for all. For those where we cannot be sure, I'm suggesting to simply show no link.

@Fastidious
Copy link

The list is close to impossible to maintain, and it will be huge. Simply stating "check your mail to finish your account... etc." should be fine. Having the button with "OK" to return back to forum root (or perhaps to login screen) sounds acceptable [to me].

@franzliedke
Copy link
Contributor Author

It doesn't have to be huge. The idea is to cover many people with just a few (max. 10) providers. But maybe I'm wrong and that would only list good results in the Western world...

@tobyzerner
Copy link
Contributor

that would only list good results in the Western world

I guess that's still OK though, at least some users will get the benefit rather than no one! I don't think it's worth the extra complexity to make this list long/configurable though.

How about we just use this list? http://www.thewindowsclub.com/commonly-used-email-addresses

@InfoLibre
Copy link

The idea is good but even with most common providers, the webmail address can change or the name of the provider can change (Google->Alphabet) or the provider can be sold. If you don't add a way for each user to suggest corrections or new names, the list will be obsolete in one or two years.
A new list could be proposed in each new Flarum versions and as a separate file in which we could add ourself our own webmail address that exist in our land or could be edited directly from Flarum, in the admin panel.
It could be a separated project that could interest other softwares.

@franzliedke
Copy link
Contributor Author

I'm pretty sure the ones on the list Toby posted haven't changed in a long time. Why should they? Users are interested in keeping their email address...

@InfoLibre
Copy link

About this list :
With Google Apps for Business, each organization has its own domain.
mail.com, inbox.com, zoho.com, thewindowsclub.com are not very know in the world and they could disappear or change their name.
I'm not sure aol.com is still used a lot and it will disappear one day like so many others.
If you add a list (and it's a good idea) but don't add a way for each user to modify it, your work will be lost in a few years.

@Mecvak
Copy link

Mecvak commented Sep 26, 2015

I feel like in this case, it's a high investment, low yield kind of thing.

  • When told to go confirm their email, the users will probably remember what email they just used
  • The user probably has a far more efficient method of quickly accessing their email then attempting to guess what that is.

I mean, a user might already have it open, another might use a client and another might have email open on their phone and simply use that to activate it.

Flarum feels far too... modular to limit itself by hard coding in some white-listed domains.
Why not leave it up to the user in the admin area? If they list a domain, it'll provide a link to that domain and otherwise no.

Also, a replacement to that spot might be a code entry. Either click on the link or fill in the n character long code (sent by email) to activate. - Speculating.

@zaksoup
Copy link

zaksoup commented Sep 26, 2015

I'm definitely in agreement with @Mecvak. If this feature survives at all it should definitely be in the form of a whitelist managed by the admins. I feel like this feature will only be a convenience in the rare case when the user doesn't already have their email open in a different tab. Between push notifications to chrome if you're signed into gmail or your tablet/phone/desktop client I'm honestly not sure that this feature will benefit any reasonable number of users whose emails have a web client.

@franzliedke
Copy link
Contributor Author

Hmm, it's becoming harder and harder to justify this. :-/

Unless you're very fond of it, @tobscure, I'd just vote to drop this feature at this point. It's too hard to maintain (and judge what to maintain), combined with lots of opportunity for confusion.
I like the thought behind it; but we can keep such niceties in mind, and I'm sure we'll find other places where stuff like this is even more helpful.

tobyzerner added a commit to flarum/lang-english that referenced this issue Sep 29, 2015
@tobyzerner
Copy link
Contributor

@franzliedke Well said. I've replaced all instances of these "go to email provider" buttons with simple "OK" buttons.

@dcsjapan
Copy link
Contributor

Back to dismiss buttons then?

Okay, noting it in my reference YAML so I can mention it in the i18n docs.

askvortsov1 pushed a commit to flarum/lang-english that referenced this issue Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants