New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a whitelist for popular email provider weblinks #541
Comments
@franzliedke as I commented on one of those tickets :-) :
|
Of course we can't do it for all. For those where we cannot be sure, I'm suggesting to simply show no link. |
France : Others : https://fr.wikipedia.org/wiki/Liste_de_fournisseurs_d'acc%C3%A8s_%C3%A0_Internet_pour_particuliers Should add a link in Flarum to let possibility to add/delete/modify theses links somewhere because the list will change a lot of times. |
The list is close to impossible to maintain, and it will be huge. Simply stating "check your mail to finish your account... etc." should be fine. Having the button with "OK" to return back to forum root (or perhaps to login screen) sounds acceptable [to me]. |
It doesn't have to be huge. The idea is to cover many people with just a few (max. 10) providers. But maybe I'm wrong and that would only list good results in the Western world... |
I guess that's still OK though, at least some users will get the benefit rather than no one! I don't think it's worth the extra complexity to make this list long/configurable though. How about we just use this list? http://www.thewindowsclub.com/commonly-used-email-addresses |
The idea is good but even with most common providers, the webmail address can change or the name of the provider can change (Google->Alphabet) or the provider can be sold. If you don't add a way for each user to suggest corrections or new names, the list will be obsolete in one or two years. |
I'm pretty sure the ones on the list Toby posted haven't changed in a long time. Why should they? Users are interested in keeping their email address... |
About this list : |
I feel like in this case, it's a high investment, low yield kind of thing.
I mean, a user might already have it open, another might use a client and another might have email open on their phone and simply use that to activate it. Flarum feels far too... modular to limit itself by hard coding in some white-listed domains. Also, a replacement to that spot might be a code entry. Either click on the link or fill in the n character long code (sent by email) to activate. - Speculating. |
I'm definitely in agreement with @Mecvak. If this feature survives at all it should definitely be in the form of a whitelist managed by the admins. I feel like this feature will only be a convenience in the rare case when the user doesn't already have their email open in a different tab. Between push notifications to chrome if you're signed into gmail or your tablet/phone/desktop client I'm honestly not sure that this feature will benefit any reasonable number of users whose emails have a web client. |
Hmm, it's becoming harder and harder to justify this. :-/ Unless you're very fond of it, @tobscure, I'd just vote to drop this feature at this point. It's too hard to maintain (and judge what to maintain), combined with lots of opportunity for confusion. |
@franzliedke Well said. I've replaced all instances of these "go to email provider" buttons with simple "OK" buttons. |
Back to dismiss buttons then? Okay, noting it in my reference YAML so I can mention it in the i18n docs. |
Seeing problems like #62, #480 and #481, we may want to consider only showing the email provider link to emails where we definitely know it works (GMail, Yahoo, Hotmail/Outlook...).
If we have a list of, say, the 10 most popular email providers, we still have a ton of people enjoying this nice touch, but don't confusion with others where we don't know whether our assumption holds...
The text was updated successfully, but these errors were encountered: