Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API links don't include /api path #579

Closed
makenosound opened this issue Oct 6, 2015 · 2 comments
Closed

API links don't include /api path #579

makenosound opened this issue Oct 6, 2015 · 2 comments
Labels
Milestone

Comments

@makenosound
Copy link

When requesting the the discussions#index from the API via a URL like http://flarum.org/api/discussion the links returned are something like:

"links": {
    "first": "http://flarum.org/discussions?page%5Boffset%5D=0",
    "next": "http://flarum.org/discussions?page%5Boffset%5D=20"
},

... which doesn’t include the /api portion of the URL. Is that intentional or just an oversight in the URL generation?

Cheers,
Max

@tobyzerner
Copy link
Contributor

Oversight indeed! I caught this too the other day. It's been fixed in the dev branch (i.e. will be fixed for beta 3).

@tobyzerner tobyzerner added this to the 0.1.0-beta.3 milestone Oct 6, 2015
@makenosound
Copy link
Author

Ah, sweet — way of ahead of me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants