Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP 1359 oauth2 improvements #1388

Closed
wants to merge 2 commits into from
Closed

WIP 1359 oauth2 improvements #1388

wants to merge 2 commits into from

Conversation

luceos
Copy link
Member

@luceos luceos commented Mar 15, 2018

fixes #1359

  • upgrades core to use league/oauth2-client
  • enriches (temporary) auth tokens received from sso provider with suggestions
  • adds sso identifier (class or controller class) to table
  • look at avatarUrl vulnerability in this situation, eg mitigate other points of entry

@tobyzerner tobyzerner mentioned this pull request Jul 20, 2018
Merged
2 tasks
@tobyzerner
Copy link
Contributor

Closing in favour of #1514

@tobyzerner tobyzerner closed this Jul 20, 2018
@tobyzerner tobyzerner deleted the 1359-oauth2-improvements branch July 20, 2018 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shortcomings of abstract oauth 2 controller
2 participants
@luceos @tobyzerner